Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use visualframe to avoid msfs bug #7297

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

Saschl
Copy link
Contributor

@Saschl Saschl commented Jun 13, 2022

Fixes #[issue_no]

Summary of Changes

According to
https://devsupport.flightsimulator.com/questions/8769/requestdataonsimobject-with-sim-frame-sometimes-st.html

the period SimFrame for receiving simconnect data might be buggy and stop updating. This might explain the issue with deltatime that sometimes appears and causes erratic behaviour. VisualFrame is potentially not affected and this is what this PR attempts to try out.

Screenshots (if necessary)

References

Additional context

This should probably tested on exp as there the issue is most present.

Discord username (if different from GitHub):

Testing instructions

  1. Fly and observe all systems for unwanted behaviour (hydraulic pressure for example). And of course: no hard banking and the plane should be controllable all the time.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

@Saschl Saschl marked this pull request as ready for review June 13, 2022 12:32
@2hwk 2hwk added the QA Tier 1 label Jun 13, 2022
@2hwk 2hwk added this to the v0.9.0 milestone Jun 13, 2022
@2hwk 2hwk modified the milestones: v0.9.0, v0.8.2 Jun 13, 2022
@johnpmaguire
Copy link
Contributor

Same fix Fenix will be applying.

@2hwk
Copy link
Member

2hwk commented Jun 13, 2022

LGTM

@2hwk 2hwk added the Exp Available on experimental branch (for testing) label Jun 13, 2022
@rockpapst1
Copy link

rockpapst1 commented Jun 13, 2022

Trainee Report
Discord:(rockpapst#3585)
Object of testing: 7297
Tier of Testing: 1
Date: (13/06/2022)
Testing Process:Flight from KLAX to KLAS
Negatives: VNAV didn't worked, no TOD or TOC where shown
Testing Results: Passed

@2hwk 2hwk enabled auto-merge (squash) June 14, 2022 13:11
@2hwk 2hwk merged commit 4b1c1bb into flybywiresim:master Jun 14, 2022
@beheh beheh removed the Exp Available on experimental branch (for testing) label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants